Skip to content

Remove kaminari-activerecord from solidus_core#6445

Open
tvdeyen wants to merge 1 commit intosolidusio:mainfrom
blish:core-remove-kaminari
Open

Remove kaminari-activerecord from solidus_core#6445
tvdeyen wants to merge 1 commit intosolidusio:mainfrom
blish:core-remove-kaminari

Conversation

@tvdeyen
Copy link
Copy Markdown
Member

@tvdeyen tvdeyen commented Apr 21, 2026

Summary

All transient gems that actually use Kaminari for pagination have it as dependency and this is the right call. Depending on kaminari in core does not make any sense, since core does not hold controllers nor views.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@tvdeyen tvdeyen requested a review from a team as a code owner April 21, 2026 08:17
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Apr 21, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.66%. Comparing base (20161a3) to head (408b36b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6445   +/-   ##
=======================================
  Coverage   89.66%   89.66%           
=======================================
  Files         990      990           
  Lines       20792    20793    +1     
=======================================
+ Hits        18644    18645    +1     
  Misses       2148     2148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen marked this pull request as draft April 21, 2026 08:30
@tvdeyen tvdeyen self-assigned this Apr 21, 2026
@tvdeyen tvdeyen force-pushed the core-remove-kaminari branch from 060bddd to b000e47 Compare April 21, 2026 11:59
@github-actions github-actions bot added the changelog:solidus_api Changes to the solidus_api gem label Apr 21, 2026
@tvdeyen tvdeyen force-pushed the core-remove-kaminari branch from b000e47 to 4ccb570 Compare April 21, 2026 12:04
All transient gems that actually use Kaminari for pagination have it
as dependency and this is the right call. Depending on kaminari in
core does not make any sense, since core does not hold controllers
nor views.
@tvdeyen tvdeyen force-pushed the core-remove-kaminari branch from 4ccb570 to 408b36b Compare April 21, 2026 12:05
@tvdeyen tvdeyen marked this pull request as ready for review April 21, 2026 12:27
@tvdeyen tvdeyen removed their assignment Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_api Changes to the solidus_api gem changelog:solidus_core Changes to the solidus_core gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants