Remove kaminari-activerecord from solidus_core#6445
Open
tvdeyen wants to merge 1 commit intosolidusio:mainfrom
Open
Remove kaminari-activerecord from solidus_core#6445tvdeyen wants to merge 1 commit intosolidusio:mainfrom
tvdeyen wants to merge 1 commit intosolidusio:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6445 +/- ##
=======================================
Coverage 89.66% 89.66%
=======================================
Files 990 990
Lines 20792 20793 +1
=======================================
+ Hits 18644 18645 +1
Misses 2148 2148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
060bddd to
b000e47
Compare
b000e47 to
4ccb570
Compare
All transient gems that actually use Kaminari for pagination have it as dependency and this is the right call. Depending on kaminari in core does not make any sense, since core does not hold controllers nor views.
4ccb570 to
408b36b
Compare
jarednorman
approved these changes
Apr 21, 2026
jarednorman
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All transient gems that actually use Kaminari for pagination have it as dependency and this is the right call. Depending on kaminari in core does not make any sense, since core does not hold controllers nor views.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: