Only fire order recalculated events after save#6447
Open
jarednorman wants to merge 1 commit intosolidusio:mainfrom
Open
Only fire order recalculated events after save#6447jarednorman wants to merge 1 commit intosolidusio:mainfrom
jarednorman wants to merge 1 commit intosolidusio:mainfrom
Conversation
github-actions
Bot
added
the
changelog:solidus_core
jarednorman
changed the title
The events should be published only once the transaction has completed, so any jobs fired from subscribers see the new version of the order. Also, the event bus has a job-backed backend (that I'm not sure anyone uses) so this should also fix race conditions with that. Besides fixing race conditions with subscribers, this also ensure we don't fire the event when the order is *not* being persisted.
jarednorman
force-pushed
the
order-updated-event-timing
branch
from
1dc997b to
9a2cda1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6447 +/- ##
=======================================
Coverage 89.66% 89.66%
=======================================
Files 990 990
Lines 20792 20793 +1
=======================================
+ Hits 18644 18645 +1
Misses 2148 2148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@jarednorman worth back porting to 4.7? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The events should be published only once the transaction has completed, so any jobs fired from subscribers see the new version of the order. Also, the event bus has a job-backed backend (that I'm not sure anyone uses) so this should also fix race conditions with that.
Besides fixing race conditions with subscribers, this also ensure we don't fire the event when the order is not being persisted.