WIP: Introduce new middleware stock coordinator#6484
Draft
sofiabesenski4 wants to merge 11 commits into
Draft
Conversation
We want to support additional keyword arguments to this class and a positional argument interferes with this. Co-authored-by: Jared Norman <jared@super.gd> Co-authored-by: Adam Mueller <adam@super.gd> Co-authored-by: Noah Silvera <noah@super.gd>
github-actions
Bot
added
the
changelog:solidus_core
5 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6484 +/- ##
==========================================
+ Coverage 89.68% 89.72% +0.03%
==========================================
Files 991 1000 +9
Lines 20832 20932 +100
==========================================
+ Hits 18683 18781 +98
- Misses 2149 2151 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Noah Silvera <noah@super.gd> Co-authored-by: Adam Mueller <adam@super.gd>
sofiabesenski4
force-pushed
the
introduce-new-middleware-stock-coordinator
branch
from
6b44d32 to
4a86af5
Compare
Co-authored-by: Noah Silvera <noah@super.gd> Co-authored-by: Adam Mueller <adam@super.gd>
This starts the pattern of delegating low level operations to middleware objects.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
sofiabesenski4
force-pushed
the
introduce-new-middleware-stock-coordinator
branch
from
4a86af5 to
ca9ae0d
Compare
jarednorman
requested changes
May 14, 2026
Comment on lines
+6
to
+9
| context[:availability] = Spree::Stock::Availability.new( | ||
| variants: context[:desired].variants, | ||
| stock_locations: context[:stock_locations] | ||
| ) |
Member
There was a problem hiding this comment.
This is definitely an example of how overusing this approach makes the code worse. This has seriously obfuscated the dependency chain of the availability and desired variants objects. If we have some dependent computed stuff like this, maybe we just make this methods on the context object or something? It's worth considering this further.
Contributor
Author
There was a problem hiding this comment.
Agreed! I didn't put too much thought into how things shook out entirely at this point in the draft. Will definitely revisit before opening for review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
This refactoring of the existing SimpleCoordinator leaves it in a state that retains the original functionality, and higher level shape, but encapsulates the lower level logic into middleware components.
Next steps will be to reconsider how the middleware components are encapsulated, setting up the middleware orchestration, and adding unit specs to prevent regressions.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: