[v4.7] Fix SolidusPromotion OrderRecalculator patch#6487
Open
solidus-bot[bot] wants to merge 1 commit into
Open
[v4.7] Fix SolidusPromotion OrderRecalculator patch#6487solidus-bot[bot] wants to merge 1 commit into
solidus-bot[bot] wants to merge 1 commit into
Conversation
The method signature of the InMemoryOrderUpdater changed to include the `persist` flag. This would previously raise an ArgumentError after configuring the app to use the InMemoryOrderUpdater, and passing an explicit argument for persist. Co-authored-by: Adam Mueller <adam@super.gd> (cherry picked from commit 4feb6ec)
solidus-bot
Bot
added
changelog:solidus_promotions
5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4.7 #6487 +/- ##
=======================================
Coverage 89.67% 89.67%
=======================================
Files 990 991 +1
Lines 20796 20802 +6
=======================================
+ Hits 18648 18654 +6
Misses 2148 2148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 similar comment
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4.7 #6487 +/- ##
=======================================
Coverage 89.67% 89.67%
=======================================
Files 990 991 +1
Lines 20796 20802 +6
=======================================
+ Hits 18648 18654 +6
Misses 2148 2148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tvdeyen
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov4.7:Questions ?
Please refer to the Backport tool documentation