Fix admin user edit link for custom user classes#6508
Open
minhluuquang wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
changelog:solidus_backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4010.
This updates the legacy admin users index edit action to link directly to
edit_admin_user_pathinstead of the admin user show path. That keeps the edit URL independent of the configuredSpree.user_classname and avoids relying on the show action redirect.The existing custom user class render spec now also asserts that the edit icon points to the admin user edit route.
Tests:
backend/:bundle exec rspec spec/controllers/spree/admin/users_controller_spec.rbbundle exec standardrb backend/spec/controllers/spree/admin/users_controller_spec.rbbundle exec rake lint:erb