Merged
Conversation
jarednorman
approved these changes
Dec 2, 2024
mamhoff
force-pushed
the
set-user-class-early
branch
from
b8863d2 to
008d9b1
Compare
Member
|
Specs fixed by #253 |
tvdeyen
approved these changes
Dec 16, 2024
jarednorman
approved these changes
Dec 16, 2024
tvdeyen
force-pushed
the
set-user-class-early
branch
from
008d9b1 to
421273f
Compare
For most of the Rails boot process, an app running solidus_auth_devise believes that its user class is whatever is configured in the config/spree.rb initializer. However, if `solidus_auth_devise` is installed, that is changed after most things have been configured. It need not be this way: If we want this gem to set a default, we should set it really early on, not in one of the last initializers to run (they also run alphabetically, so `solidus_auth_devise` initializers run quite late.
auto-merge was automatically disabled
December 17, 2024 09:55
Head branch was pushed to by a user without write access
mamhoff
force-pushed
the
set-user-class-early
branch
from
421273f to
14d176f
Compare
With the generated dummy `spree.rb` now running after the default in the solidus_auth_devise `engine.rb`, we need to make sure that `config/initializers/spree.rb` contains the correct user class. Before this commit, it would generate one with the `Spree::LegacyUser`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For most of the Rails boot process, an app running solidus_auth_devise believes that its user class is whatever is configured in the config/spree.rb initializer. However, if
solidus_auth_deviseis installed, that is changed after most things have been configured.It need not be this way: If we want this gem to set a default, we should set it really early on, not in one of the last initializers to run (they also run alphabetically, so
solidus_auth_deviseinitializers run quite late).Specifically, for using the new patch mechanism in https://github.com/friendlycart/flickwerk,
Spree.user_classneeds to be correct by the time the Rails finisher runs (when thesetup_main_autoloaderinitializer runs).Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: