Do not reload routes before application startup#255
Merged
kennyadsl merged 1 commit intosolidusio:mainfrom Jan 7, 2025
Merged
Conversation
This devise.rb initializer is run for most stores, and by setting `reload_routes` to `false`, we can avoid Devise reloading the routes in an initializer. Rails will do this just fine, but not in the initializer chain.
tvdeyen
approved these changes
Jan 6, 2025
Member
|
@solidusio/core-team can I get a second review? |
adammathys
approved these changes
Jan 6, 2025
Member
|
Thanks Martin, what problem does this change solve exactly? |
Contributor
Author
|
It stops every store from loading the routes twice during startup. |
Member
|
And we have this problem on all extensions? |
Contributor
Author
|
No, it's just this one, because it loads |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This devise.rb initializer is run for most stores, and by setting
reload_routestofalse, we can avoid Devise reloading the routes in an initializer. Rails will do this just fine, but not in the initializer chain.