Skip to content

Install Bundler gem helper tasks#129

Closed
tvdeyen wants to merge 1 commit intosolidusio:masterfrom
tvdeyen:add-bundler-gem-tasks
Closed

Install Bundler gem helper tasks#129
tvdeyen wants to merge 1 commit intosolidusio:masterfrom
tvdeyen:add-bundler-gem-tasks

Conversation

@tvdeyen
Copy link
Copy Markdown
Member

@tvdeyen tvdeyen commented Aug 6, 2020

Very useful for building and releasing gems

Checklist

  • I have structured the commits for clarity and conciseness.
  • I have added relevant automated tests for this change.

Very useful for building and releasing gems
@mergify mergify Bot added the needs changelog label Needs a label to determine the type of change. label Aug 6, 2020
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Aug 6, 2020

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

  • bug for bugfixes.
  • enhancement for new features and improvements.
  • documentation for documentation changes.
  • security for security patches.
  • removed for feature removals.
  • infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

  • breaking for breaking changes.
  • deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

@tvdeyen tvdeyen added enhancement Improves an existing feature. and removed needs changelog label Needs a label to determine the type of change. labels Aug 6, 2020
@tvdeyen
Copy link
Copy Markdown
Member Author

tvdeyen commented Aug 6, 2020

Just saw that we already use the gem-release gem. Why? Bundler has gem support build right in.

But anyhow the release tasks are not included in the extensions take tasks. That should be fixed either way.

@tvdeyen tvdeyen added the question Asks clarifications about the project. label Aug 6, 2020
@tvdeyen
Copy link
Copy Markdown
Member Author

tvdeyen commented Aug 6, 2020

gem-release has much more features that are very helpful. Closing

@tvdeyen tvdeyen closed this Aug 6, 2020
@tvdeyen tvdeyen deleted the add-bundler-gem-tasks branch August 6, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improves an existing feature. question Asks clarifications about the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant