Skip to content

bump codecov to ~> 0.2, since 0.1.X are all yanked#130

Merged
elia merged 1 commit intosolidusio:masterfrom
peterberkenbosch:bump-codecov
Aug 21, 2020
Merged

bump codecov to ~> 0.2, since 0.1.X are all yanked#130
elia merged 1 commit intosolidusio:masterfrom
peterberkenbosch:bump-codecov

Conversation

@peterberkenbosch
Copy link
Copy Markdown
Contributor

according to https://rubygems.org/gems/codecov/versions all the 0.1.X gems are yanked.

This PR updated the dependency to 0.2

@mergify mergify Bot added the needs changelog label Needs a label to determine the type of change. label Aug 20, 2020
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Aug 20, 2020

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

  • bug for bugfixes.
  • enhancement for new features and improvements.
  • documentation for documentation changes.
  • security for security patches.
  • removed for feature removals.
  • infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

  • breaking for breaking changes.
  • deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

@elia elia added infrastructure Internal change — changelog entry not needed. and removed needs changelog label Needs a label to determine the type of change. labels Aug 21, 2020
@elia
Copy link
Copy Markdown
Member

elia commented Aug 21, 2020

The failure on master is unrelated, I'll force-merge this as it's preventing all extension PRs from passing. Wondering how they ended up with such a dramatic decision 🙀

@elia elia merged commit 1c41746 into solidusio:master Aug 21, 2020
@brchristian
Copy link
Copy Markdown
Contributor

Wow, this is one of the stranger things I've ever seen.

@elia Any chance we could get a new rubygems release with this PR in it? It looks like most extensions with dependencies on solidus_dev_support are still failing CI because they're looking for a compatible gem version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Internal change — changelog entry not needed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants