Add Zeitwerk deprecation warning#95
Merged
mergify[bot] merged 1 commit intosolidusio:masterfrom May 22, 2020
Merged
Conversation
Contributor
|
Hi @AlessioRocco, this seems still very relevant right? Should we make this happen? |
AlessioRocco
force-pushed
the
zeitwerk-deprecation-warning
branch
8 times, most recently
from
065576e to
8540b01
Compare
This makes the build fail when extensions are tested against a Rails version that supports Zeitwerk and the autoloader is not able to load module/classes defined in the extension.
AlessioRocco
force-pushed
the
zeitwerk-deprecation-warning
branch
from
8540b01 to
9d11277
Compare
aldesantis
approved these changes
May 22, 2020
jarednorman
pushed a commit
to SuperGoodSoft/solidus_dev_support
that referenced
this pull request
Feb 4, 2026
…x-support Relax solidus_support dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the build fail when extensions are tested against a Rails version that supports Zeitwerk and the autoloader is not able to load module/classes defined in the extension.
This simulates a failure that could happen in staging/production, when Rails
eager_loadis set to true.Checklist
I have added relevant automated tests for this change.