Fix specs for Solidus version >= 2.11.0.alpha#105
Merged
AlessioRocco merged 1 commit intomasterfrom Apr 24, 2020
Merged
Conversation
The Solidus address factory was changed in this commit: solidusio/solidus@12bdceb#diff-bcf5b7751ffe7e9a0b057cf8e449951f and the lastname is now "Von Doe" instead of nil, this fixes the issue modifying the original factory and setting the firstname and lastname.
AlessioRocco
force-pushed
the
fix-master-failing-specs
branch
from
4c1ed62 to
ce16c71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Solidus address factory was changed in this commit:
solidusio/solidus@12bdceb#diff-bcf5b7751ffe7e9a0b057cf8e449951f
and the lastname is now "Von Doe" instead of nil, this fixes the issue
modifying the original factory and setting the firstname and lastname.