Add Adjustment types and the adjustments connection to the Order type#121
Merged
rainerdema merged 5 commits intomasterfrom Jul 3, 2020
Merged
Add Adjustment types and the adjustments connection to the Order type#121rainerdema merged 5 commits intomasterfrom
rainerdema merged 5 commits intomasterfrom
Conversation
rainerdema
force-pushed
the
rainerd/add-adjustment-type
branch
2 times, most recently
from
8298f02 to
800057c
Compare
rainerdema
force-pushed
the
rainerd/add-adjustment-type
branch
from
800057c to
7e71db5
Compare
rainerdema
changed the title
rainerdema
force-pushed
the
rainerd/add-adjustment-type
branch
5 times, most recently
from
8f98c34 to
a232c39
Compare
rainerdema
requested review from
AlessioRocco,
ChristianRimondi and
SamuelMartini
It adds the `PromotionAdjustment` type, based on `Spree::PromotionAction`.
It adds the `TaxAdjustment` type, based on `Spree::TaxRate`.
It adds the `Adjustment` interface and implements it in the new `TaxAdjustment` and `PromotionAdjustment` types. These are declared as `orphan_types` because they are never used directly but only connected through the `Adjustment` interface. For more information about this: https://graphql-ruby.org/type_definitions/interfaces.html#orphan-types
Using command "bundle exec rake schema:idl"
rainerdema
force-pushed
the
rainerd/add-adjustment-type
branch
from
a232c39 to
a0cc481
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
PromotionAdjustmentand theTaxAdjustmenttypesAdjustmentinterface and implements it in the new types.adjustmentsconnection to theOrdertype