Skip to content

Add Address type#13

Merged
ChristianRimondi merged 1 commit intomasterfrom
address-type
Oct 18, 2019
Merged

Add Address type#13
ChristianRimondi merged 1 commit intomasterfrom
address-type

Conversation

@rainerdema
Copy link
Copy Markdown
Contributor

@rainerdema rainerdema commented Sep 27, 2019

Add AddressType. It will be used in the UserType:

  • Add primitive fields;
  • Add Spree::Queries::Address::Country query object with a batch loader to retrieve the country of the address;
  • Add Spree::Queries::Address::State query object with a batch loader to retrieve the state of the address;
  • Add some query object specs to test the correct return of the batch loaders.

@rainerdema rainerdema added the WIP Work in progress label Sep 27, 2019
@rainerdema rainerdema self-assigned this Sep 27, 2019
@rainerdema rainerdema changed the base branch from user-type to master October 18, 2019 11:31
@rainerdema rainerdema removed the WIP Work in progress label Oct 18, 2019
@rainerdema rainerdema marked this pull request as ready for review October 18, 2019 12:15
@rainerdema rainerdema force-pushed the address-type branch 2 times, most recently from 47aa52a to e89d633 Compare October 18, 2019 13:45
@rainerdema rainerdema force-pushed the address-type branch 2 times, most recently from e840a7c to ea490ff Compare October 18, 2019 14:21
Copy link
Copy Markdown
Contributor

@ChristianRimondi ChristianRimondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

It uses:
- The Spree::Queries::Address::Country query object
with a batch loader to retrieve the country of the address;
- The Spree::Queries::Address::State query object
with a batch loader to retrieve the state of the address.
@ChristianRimondi ChristianRimondi merged commit 7d10d99 into master Oct 18, 2019
@ChristianRimondi ChristianRimondi deleted the address-type branch October 18, 2019 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants