Type Customization API#20
Merged
AlessioRocco merged 1 commit intomasterfrom Jan 24, 2020
Merged
Conversation
aldesantis
force-pushed
the
customization
branch
from
e5f61ea to
e590545
Compare
aldesantis
force-pushed
the
customization
branch
2 times, most recently
from
6118187 to
fb18afb
Compare
aldesantis
force-pushed
the
customization
branch
from
fb18afb to
59624de
Compare
aldesantis
force-pushed
the
customization
branch
2 times, most recently
from
edf4a92 to
2bc41e7
Compare
This allows users to remove previously defined fields (e.g. for security reasons) when they are overriding our types.
AlessioRocco
requested review from
AlessioRocco,
ChristianRimondi and
mdesantis
aldesantis
force-pushed
the
customization
branch
from
2bc41e7 to
4ee1f49
Compare
ChristianRimondi
approved these changes
Jan 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users to customize our implementation by providing the ability to remove previously defined fields (via
.remove_field).Fields can already be redefined by calling
fieldagain, so we shouldn't need much more.