Skip to content

Add ProductProperty Type#26

Merged
ChristianRimondi merged 1 commit intomasterfrom
product-property-type
Oct 11, 2019
Merged

Add ProductProperty Type#26
ChristianRimondi merged 1 commit intomasterfrom
product-property-type

Conversation

@AlessioRocco
Copy link
Copy Markdown
Contributor

@AlessioRocco AlessioRocco commented Oct 11, 2019

Add ProductProperty Type that will be used in the Product Type.
It has basic fields and the property field loaded with the batch loader inside a query object.

@AlessioRocco AlessioRocco force-pushed the product-property-type branch from ce62658 to a76e845 Compare October 11, 2019 15:21
@AlessioRocco AlessioRocco self-assigned this Oct 11, 2019
@AlessioRocco AlessioRocco marked this pull request as ready for review October 11, 2019 15:21
@AlessioRocco AlessioRocco force-pushed the product-property-type branch from a76e845 to 9d7b172 Compare October 11, 2019 15:35
It uses the Spree::Queries::ProductProperty::PropertyQuery query object
with a batch loader to retrieve the property of the product property.
@AlessioRocco AlessioRocco force-pushed the product-property-type branch from 9d7b172 to 3059fee Compare October 11, 2019 15:51
Copy link
Copy Markdown
Contributor

@ChristianRimondi ChristianRimondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ChristianRimondi ChristianRimondi merged commit 2fdb4b0 into master Oct 11, 2019
@ChristianRimondi ChristianRimondi deleted the product-property-type branch October 11, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants