Add properties to product type#27
Merged
ChristianRimondi merged 3 commits intomasterfrom Oct 18, 2019
Merged
Conversation
AlessioRocco
force-pushed
the
add-properties-to-product-type
branch
from
3d74ad9 to
a1cbeef
Compare
Looking at solidus core it can be nil.
AlessioRocco
force-pushed
the
add-properties-to-product-type
branch
from
a1cbeef to
dc23208
Compare
It adds the product properties connection field to the Product Type and uses the Spree::Queries::Product::ProductPropertiesQuery query object with batch loader to retrieve the product properties.
Using command "bundle exec rake schema:idl"
AlessioRocco
force-pushed
the
add-properties-to-product-type
branch
from
dc23208 to
4ebede3
Compare
ChristianRimondi
approved these changes
Oct 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
product_propertiesfield toProducttype.