Add images connection field to Variant Type#29
Merged
ChristianRimondi merged 3 commits intomasterfrom Nov 29, 2019
Merged
Conversation
AlessioRocco
force-pushed
the
add-image-connection-to-product
branch
from
8a02216 to
6fe55c5
Compare
AlessioRocco
force-pushed
the
add-image-connection-to-product
branch
from
6fe55c5 to
6517db2
Compare
AlessioRocco
force-pushed
the
add-image-connection-to-product
branch
7 times, most recently
from
173a001 to
476c0cf
Compare
It has basic informations and an urls for the styles provided by solidus.
AlessioRocco
force-pushed
the
add-image-connection-to-product
branch
from
476c0cf to
6323611
Compare
It adds the images connection field to the Variant Type and uses the SolidusGraphqlApi::Queries::Variant::ImagesQuery query object with batch loader to retrieve the images.
Using command "bundle exec rake schema:idl"
AlessioRocco
force-pushed
the
add-image-connection-to-product
branch
from
6323611 to
b4d6d24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It adds the images connection field to the Variant Type and uses the
SolidusGraphqlApi::Queries::Variant::ImagesQueryquery object with batch loader to retrieve the images.