Fix CircleCI specs errors#32
Merged
ChristianRimondi merged 3 commits intomasterfrom Nov 15, 2019
Merged
Conversation
This PR[1] on the solidusio/circleci-orbs-extensions has changed the circleci environment variable we used in the Gemfile to load the correct database gem. [1]: https://github.com/solidusio/circleci-orbs-extensions/pull/17/files#diff-8b920f97de502b46d6f53a9fd0a9bd05R4-L7
We don't care about the order of the returning result, only its contents.
Not passing this option causes a `Mysql2::Error: SAVEPOINT active_record_1 does not exist` exception when using MySQL with the specs. Based on this pr[1], the correct way to use `with_model` together with DatabaseCleaner and MySQL, is to not use the default `each` scope. [1]: Casecommons/with_model#18
ChristianRimondi
force-pushed
the
fix-circleci-specs
branch
from
4712b72 to
4cc713f
Compare
ChristianRimondi
changed the title
AlessioRocco
approved these changes
Nov 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.