Add addresses field to user type#34
Merged
ChristianRimondi merged 2 commits intomasterfrom Nov 29, 2019
Merged
Conversation
rainerdema
force-pushed
the
add-addresses-to-user-type
branch
10 times, most recently
from
c0b12f9 to
faa2130
Compare
rainerdema
requested review from
AlessioRocco and
ChristianRimondi
and removed request for
ChristianRimondi
AlessioRocco
changed the title
rainerdema
force-pushed
the
add-addresses-to-user-type
branch
2 times, most recently
from
f55bf16 to
f5ceff8
Compare
- Adds: + A generic `addresses` node + `defaultAddress` + `billAddress ` `Types::Address` fields to the User Type. - Update expected_schema with all address fields.
Using command "bundle exec rake schema:idl"
rainerdema
force-pushed
the
add-addresses-to-user-type
branch
from
f5ceff8 to
e2a9a84
Compare
ChristianRimondi
approved these changes
Nov 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the following
Types::Addressfields to the User Type:addressesnode:[]defaultAddressshipAddressbillAddress