Improve Helpers::Graphql.execute_query spec helper#51
Merged
AlessioRocco merged 5 commits intomasterfrom Dec 6, 2019
Merged
Conversation
AlessioRocco
force-pushed
the
improve-execute_query-spec-helper
branch
3 times, most recently
from
c6be99a to
aa105d7
Compare
AlessioRocco
force-pushed
the
improve-execute_query-spec-helper
branch
from
aa105d7 to
4f91cbb
Compare
AlessioRocco
requested review from
ChristianRimondi,
mdesantis and
rainerdema
AlessioRocco
force-pushed
the
improve-execute_query-spec-helper
branch
4 times, most recently
from
c453824 to
293a118
Compare
Leave it under the spec root folder caused some misunderstanding on the purpose of these graphql queries.
This allows using variables with our graphql spec queries. Add it also to the 'query is successful' shared example.
This transforms all the result query ids from the UUID to the Rails model id and allows the specs to compare the ids directly without the need to convert it every time.
It manage how the query response is parsed and it's OpenStruct by default.
AlessioRocco
force-pushed
the
improve-execute_query-spec-helper
branch
from
293a118 to
d7f543a
Compare
AlessioRocco
force-pushed
the
improve-execute_query-spec-helper
branch
from
d7f543a to
3f70203
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the
Helpers::Graphql.execute_querywith:spec/support