Skip to content

Add order type and orders connection#54

Merged
ChristianRimondi merged 3 commits intomasterfrom
mdesantis/add-order-type-and-orders-connection
Feb 7, 2020
Merged

Add order type and orders connection#54
ChristianRimondi merged 3 commits intomasterfrom
mdesantis/add-order-type-and-orders-connection

Conversation

@mdesantis
Copy link
Copy Markdown

@mdesantis mdesantis commented Nov 29, 2019

Closes #45. It adds the Order type, based on Spree::Order, and the completedOrders query, which returns the completed orders associated to the current user.

@mdesantis mdesantis force-pushed the mdesantis/add-order-type-and-orders-connection branch from fada92a to db9a345 Compare November 29, 2019 17:26
@mdesantis mdesantis marked this pull request as ready for review December 6, 2019 08:33
@mdesantis mdesantis self-assigned this Dec 6, 2019
@mdesantis mdesantis added the enhancement New feature or request label Dec 6, 2019
@mdesantis mdesantis added this to the Checkout Flow milestone Dec 6, 2019
@mdesantis mdesantis added the WIP Work in progress label Dec 6, 2019
@mdesantis mdesantis force-pushed the mdesantis/add-order-type-and-orders-connection branch from db9a345 to 22ff602 Compare December 6, 2019 15:39
@ChristianRimondi ChristianRimondi mentioned this pull request Dec 13, 2019
@mdesantis mdesantis force-pushed the mdesantis/add-order-type-and-orders-connection branch 2 times, most recently from 896a2d8 to 68b3ca7 Compare January 10, 2020 09:46
@mdesantis mdesantis force-pushed the mdesantis/add-order-type-and-orders-connection branch 2 times, most recently from cecfc0a to 13a6f25 Compare January 24, 2020 13:38
@mdesantis mdesantis removed the WIP Work in progress label Jan 24, 2020
Comment thread spec/integration/completed_orders_spec.rb Outdated
@mdesantis mdesantis force-pushed the mdesantis/add-order-type-and-orders-connection branch 3 times, most recently from cc251eb to d6292e4 Compare January 24, 2020 15:37
Maurizio De Santis added 3 commits February 7, 2020 11:57
It adds the `Order` type, based on `Spree::Order`.
It adds the `completedOrders` query, which returns the completed orders
associated to the current user.
It gets rid of a false positive when the query doesn't raise exceptions 
but it returns results with errors.
@mdesantis mdesantis force-pushed the mdesantis/add-order-type-and-orders-connection branch from d6292e4 to 2bab5ef Compare February 7, 2020 10:57
Copy link
Copy Markdown
Contributor

@ChristianRimondi ChristianRimondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Contributor

@AlessioRocco AlessioRocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ChristianRimondi ChristianRimondi merged commit 47cd6f1 into master Feb 7, 2020
@ChristianRimondi ChristianRimondi deleted the mdesantis/add-order-type-and-orders-connection branch February 7, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Order Type and related Connections and Types

3 participants