Improve current store query specs#56
Merged
ChristianRimondi merged 1 commit intomasterfrom Dec 13, 2019
Merged
Conversation
AlessioRocco
force-pushed
the
add-snapshot-specs
branch
11 times, most recently
from
7e30387 to
e9bc86f
Compare
AlessioRocco
force-pushed
the
improve-current-store-query-specs
branch
from
91cc920 to
a928868
Compare
AlessioRocco
force-pushed
the
add-snapshot-specs
branch
from
cc067a3 to
465f091
Compare
AlessioRocco
force-pushed
the
improve-current-store-query-specs
branch
from
a928868 to
81c360e
Compare
AlessioRocco
force-pushed
the
add-snapshot-specs
branch
2 times, most recently
from
343f385 to
194be47
Compare
AlessioRocco
force-pushed
the
improve-current-store-query-specs
branch
from
81c360e to
d5c3d35
Compare
AlessioRocco
force-pushed
the
add-snapshot-specs
branch
from
194be47 to
7172b66
Compare
AlessioRocco
force-pushed
the
improve-current-store-query-specs
branch
2 times, most recently
from
9e8c77d to
a5ce924
Compare
AlessioRocco
force-pushed
the
add-snapshot-specs
branch
4 times, most recently
from
18215d3 to
b8c71fd
Compare
AlessioRocco
force-pushed
the
improve-current-store-query-specs
branch
from
a5ce924 to
904d38e
Compare
AlessioRocco
force-pushed
the
improve-current-store-query-specs
branch
2 times, most recently
from
2dca06a to
2cae2b2
Compare
ChristianRimondi
previously approved these changes
Dec 13, 2019
AlessioRocco
force-pushed
the
improve-current-store-query-specs
branch
2 times, most recently
from
cf922ec to
6d62e3d
Compare
Uses the match_response custom matcher to compare the query with the expected result.
AlessioRocco
force-pushed
the
improve-current-store-query-specs
branch
from
6d62e3d to
cee6242
Compare
ChristianRimondi
approved these changes
Dec 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change specs to use snapshot results instead of test the nodes one by one.