Skip to content

Implement products search#59

Merged
ChristianRimondi merged 7 commits intomasterfrom
products_search
Mar 6, 2020
Merged

Implement products search#59
ChristianRimondi merged 7 commits intomasterfrom
products_search

Conversation

@ChristianRimondi
Copy link
Copy Markdown
Contributor

@ChristianRimondi ChristianRimondi commented Dec 6, 2019 •
edited
Loading

Rel #40

@ChristianRimondi ChristianRimondi self-assigned this Dec 6, 2019
@ChristianRimondi ChristianRimondi force-pushed the products_search branch 3 times, most recently from ba649c9 to 08c13c5 Compare January 10, 2020 09:03
@ChristianRimondi ChristianRimondi force-pushed the products_search branch 2 times, most recently from d9c0c7e to b101442 Compare January 24, 2020 13:31
@ChristianRimondi ChristianRimondi force-pushed the products_search branch 4 times, most recently from 62ad718 to dcc0a27 Compare February 7, 2020 15:21
@ChristianRimondi ChristianRimondi force-pushed the products_search branch 7 times, most recently from 0f5cdcb to ccc8c62 Compare February 21, 2020 09:31
@ChristianRimondi ChristianRimondi force-pushed the products_search branch 4 times, most recently from e36ec3d to 01f72df Compare February 21, 2020 12:50
@ChristianRimondi ChristianRimondi marked this pull request as ready for review February 21, 2020 14:44
mdesantis
mdesantis reviewed Feb 21, 2020
View reviewed changes
Copy link
Copy Markdown

@mdesantis mdesantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one concern

Comment thread lib/solidus_graphql_api/types/ransack_json.rb Outdated
AlessioRocco
AlessioRocco suggested changes Feb 21, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@AlessioRocco AlessioRocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I've only some questions and found a typo.

Comment thread spec/lib/solidus_graphql_api/context_spec.rb Outdated
Comment thread lib/solidus_graphql_api/context.rb Outdated
Comment thread spec/integration/queries/products_spec.rb Outdated
Comment thread spec/lib/solidus_graphql_api/queries/products_query_spec.rb
mdesantis
mdesantis previously requested changes Feb 28, 2020
View reviewed changes
Comment thread lib/solidus_graphql_api/types/ransack_json.rb Outdated
@ChristianRimondi ChristianRimondi force-pushed the products_search branch 4 times, most recently from a7877a9 to 0e6d49b Compare March 6, 2020 09:57
@ChristianRimondi ChristianRimondi force-pushed the products_search branch 3 times, most recently from 26f163f to c978dc9 Compare March 6, 2020 10:05
@ChristianRimondi
Add current_pricing_options to context
38a28a1
@ChristianRimondi
Add RansackJson argument type
1ecdd5c 
This custom JSON type must be used whenever we need an input argument to
deal with ransack query.

It receives a raw JSON input and converts all the relay style IDs
(base64 encoded) to the corresponding IDs that can be used in SQL
queries.
@ChristianRimondi
Add ProductsQueryInput object
be24f37
@ChristianRimondi
Name the subjects defined in the shared_contexts
e2cf01d
@ChristianRimondi
Use Spree::Config.searcher_class in the ProductsQuery
d75d25c 
ProductsQuery now uses Spree::Config.searcher_class to retrieve the
product.
@ChristianRimondi
Remove query_is_successful shared example
82a3486 
This shared example is not used anymore.
@ChristianRimondi
Update graphql schema
c582b2e
AlessioRocco
AlessioRocco approved these changes Mar 6, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@AlessioRocco AlessioRocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ChristianRimondi ChristianRimondi merged commit 6d4a433 into master Mar 6, 2020
@ChristianRimondi ChristianRimondi deleted the products_search branch March 6, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdesantis mdesantis Awaiting requested review from mdesantis

1 more reviewer

@AlessioRocco AlessioRocco AlessioRocco approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ChristianRimondi ChristianRimondi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChristianRimondi @mdesantis @AlessioRocco