Add Currency Type#62
Merged
ChristianRimondi merged 5 commits intomasterfrom Jan 24, 2020
Merged
Conversation
rainerdema
force-pushed
the
rainerd/53-add-currency-type
branch
from
a724733 to
e7bac3d
Compare
rainerdema
force-pushed
the
rainerd/53-add-currency-type
branch
3 times, most recently
from
0f4b87d to
ace534c
Compare
rainerdema
requested review from
AlessioRocco and
ChristianRimondi
and removed request for
AlessioRocco
rainerdema
force-pushed
the
rainerd/53-add-currency-type
branch
5 times, most recently
from
2b4f820 to
249241d
Compare
Based on the `::Money::Currency` model. Only the essential fields are taken into consideration.
- Add a generic `currencies` paginable node. This field return all the available currencies in the form of `Types::Currency`. For more information about this: https://github.com/solidusio/solidus/blob/7a336a71a80e3b0a447a522f6ef2b66965b0457e/core/lib/spree/app_configuration.rb#L262-L269 - Update expected_schema with all address fields.
Using command "bundle exec rake schema:idl"
Make the `schema_comparator` with the `origin/master` to avoid possible problems of corrupt files with the `master` branch in the server.
rainerdema
force-pushed
the
rainerd/53-add-currency-type
branch
from
249241d to
561031b
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick Info
Types::Currency:currenciesin theTypes::Storecurrencyin theTypes::Priceprice_spec.rbbreaking change detectionin CircleCINote
schema-breaking-change-detectionfails because is necessary to deprecate the modified fields here:SolidusGraphqlApi::Types::PriceTypeFor the moment, since the gem hasn't yet been officially released, we don't bother to deprecate the fields.