Migrate to solidus_dev_support#63
Merged
AlessioRocco merged 2 commits intomasterfrom Jan 17, 2020
Merged
Conversation
ChristianRimondi
force-pushed
the
migrate_to_solidus_dev_support
branch
4 times, most recently
from
4663d09 to
c9d0cd7
Compare
Migrate all the gem files to use this template[1] as a guide. Some of the new RuboCop rules introduced in solidus_dev_support have been disabled to let the build pass but will be fixed in a new PR. [1] https://github.com/solidusio/solidus_dev_support/tree/v0.5.0/lib/solidus_dev_support/templates/extension
ChristianRimondi
force-pushed
the
migrate_to_solidus_dev_support
branch
from
c9d0cd7 to
2797b86
Compare
As stated here[1], Code Climate plugins run in isolated environments and can't install gems or use gems installed for the repositories they're analyzing. This is a security feature that does unfortunately limit the flexibility of plugins to use our own third party plugins. For this reasons, the RuboCop checks will be moved to the CI. [1] qltysh-archive/codeclimate-rubocop#131 (comment)
ChristianRimondi
force-pushed
the
migrate_to_solidus_dev_support
branch
from
2797b86 to
d17ff19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate all the gem files to use this template as a guide.
Please note that some of the new RuboCop rules introduced in solidus_dev_support have been disabled to let the build pass but will be fixed in a new PR.