Merged
Conversation
mdesantis
requested review from
AlessioRocco,
ChristianRimondi and
rainerdema
mdesantis
force-pushed
the
mdesantis/improve-snapshot-specs-error-messages
branch
2 times, most recently
from
74b00d2 to
75bdedd
Compare
mdesantis
force-pushed
the
mdesantis/improve-snapshot-specs-error-messages
branch
2 times, most recently
from
0296196 to
b2fe18d
Compare
ChristianRimondi
previously approved these changes
Jan 24, 2020
mdesantis
force-pushed
the
mdesantis/improve-snapshot-specs-error-messages
branch
2 times, most recently
from
cfebb6f to
377809b
Compare
mdesantis
force-pushed
the
mdesantis/improve-snapshot-specs-error-messages
branch
from
377809b to
c2c9959
Compare
ChristianRimondi
previously approved these changes
Jan 24, 2020
AlessioRocco
previously approved these changes
Jan 24, 2020
It lets the snapshot specs print a usable diff in case of not matching response.
mdesantis
dismissed stale reviews from AlessioRocco and ChristianRimondi
via
0d9191f
mdesantis
force-pushed
the
mdesantis/improve-snapshot-specs-error-messages
branch
from
c2c9959 to
0d9191f
Compare
AlessioRocco
approved these changes
Jan 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It lets the snapshot specs print a usable diff in case of not matching response.
BEFORE
AFTER