Use factory for current store spec#66
Merged
AlessioRocco merged 1 commit intomasterfrom Jan 24, 2020
Merged
Conversation
AlessioRocco
force-pushed
the
use-factory-for-current-store-spec
branch
2 times, most recently
from
2cdd156 to
79b6795
Compare
AlessioRocco
force-pushed
the
use-factory-for-current-store-spec
branch
from
79b6795 to
81ab049
Compare
AlessioRocco
requested review from
ChristianRimondi,
mdesantis and
rainerdema
rainerdema
previously approved these changes
Jan 24, 2020
AlessioRocco
force-pushed
the
use-factory-for-current-store-spec
branch
from
81ab049 to
3904187
Compare
ChristianRimondi
approved these changes
Jan 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use factories to create the current store in spec