Simplify countries query specs#67
Merged
AlessioRocco merged 1 commit intomasterfrom Jan 24, 2020
Merged
Conversation
AlessioRocco
force-pushed
the
simplify-countries-specs
branch
2 times, most recently
from
dc4c46c to
5eb3b9f
Compare
AlessioRocco
requested review from
ChristianRimondi,
mdesantis and
rainerdema
Use just one query call that checks the correctness of the response and use the factories to prepare the needed data.
AlessioRocco
force-pushed
the
simplify-countries-specs
branch
from
5eb3b9f to
94a370e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use just one query call that checks the correctness of the response and
use the factories to prepare the needed data.