Add SignIn Mutation#72
Merged
AlessioRocco merged 4 commits intomasterfrom Feb 14, 2020
Merged
Conversation
AlessioRocco
force-pushed
the
login-mutation
branch
2 times, most recently
from
a2c300e to
7abe8ac
Compare
AlessioRocco
changed the base branch from
master
to
add-mutation-spec-helpers
AlessioRocco
force-pushed
the
login-mutation
branch
from
7abe8ac to
04970b7
Compare
AlessioRocco
force-pushed
the
add-mutation-spec-helpers
branch
2 times, most recently
from
bf7858f to
44944b4
Compare
AlessioRocco
force-pushed
the
login-mutation
branch
2 times, most recently
from
b603af1 to
057e090
Compare
AlessioRocco
force-pushed
the
add-mutation-spec-helpers
branch
5 times, most recently
from
679cef6 to
74b16f2
Compare
AlessioRocco
force-pushed
the
login-mutation
branch
from
057e090 to
68c8446
Compare
AlessioRocco
changed the base branch from
add-mutation-spec-helpers
to
master
AlessioRocco
force-pushed
the
login-mutation
branch
3 times, most recently
from
bd9dd70 to
4f3d3a7
Compare
AlessioRocco
requested review from
ChristianRimondi,
mdesantis and
rainerdema
mdesantis
suggested changes
Feb 14, 2020
mdesantis
left a comment
mdesantis
left a comment
There was a problem hiding this comment.
A major concern about the method used in order to find the user to be authenticated, and some other minor concerns
AlessioRocco
force-pushed
the
login-mutation
branch
2 times, most recently
from
224ecdf to
31c55eb
Compare
AlessioRocco
force-pushed
the
login-mutation
branch
from
31c55eb to
044dac9
Compare
It's needed after the signIn/signUp to authenticate the requests.
We use "GraphQL::Schema::RelayClassicMutation" as a base class to support Relay Classic mutation specification.
AlessioRocco
force-pushed
the
login-mutation
branch
from
044dac9 to
981770a
Compare
mdesantis
approved these changes
Feb 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#43
Add the mutation to SignIn a User by using Relay Classic conventions.