Fix nullable fields in all types#82
Merged
rainerdema merged 3 commits intomasterfrom Mar 20, 2020
Merged
Conversation
rainerdema
force-pushed
the
rainerd/fix-nullable-fields-in-all-types
branch
3 times, most recently
from
face49a to
6b06a12
Compare
rainerdema
force-pushed
the
rainerd/fix-nullable-fields-in-all-types
branch
2 times, most recently
from
51ea50f to
8b2f644
Compare
Based on presence validations in `Spree::Address`: https://github.com/solidusio/solidus/blob/master/core/app/models/spree/address.rb#L14-L16
Based on presence validations in `Spree::Store`: https://github.com/solidusio/solidus/blob/d04ff9063e8048858acde5a8cac42933de3c28a3/core/app/models/spree/store.rb#L20-L23
Using command "bundle exec rake schema:idl"
rainerdema
force-pushed
the
rainerd/fix-nullable-fields-in-all-types
branch
from
8b2f644 to
3168fa0
Compare
ChristianRimondi
approved these changes
Mar 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick Info
Incorrectly declared fields were found in the following types:
SolidusGraphqlApi::Types::AddressSolidusGraphqlApi::Types::StoreAll changes are made by comparing the GraphQL types with the validations present in their Solidus models.
Note
The null settings in
SolidusGraphqlApi::Types::Addressof these two fields:Depends since the Boolean return value of these two
Spree::Addressinstance methods (true):The current type definition refers to the current default configuration in Solidus.