Add removeFromAddressBook mutation#85
Merged
AlessioRocco merged 2 commits intomasterfrom Mar 13, 2020
Merged
Conversation
AlessioRocco
force-pushed
the
remove-from-address-book-mutation
branch
2 times, most recently
from
a4fb936 to
1725a96
Compare
AlessioRocco
force-pushed
the
remove-from-address-book-mutation
branch
from
1725a96 to
aaa5f6e
Compare
AlessioRocco
changed the title
Closed
3 tasks
AlessioRocco
force-pushed
the
save-in-address-book
branch
from
aceba5e to
43f54f3
Compare
AlessioRocco
force-pushed
the
remove-from-address-book-mutation
branch
2 times, most recently
from
657b982 to
8566fce
Compare
AlessioRocco
force-pushed
the
save-in-address-book
branch
5 times, most recently
from
a32ef01 to
885ff42
Compare
AlessioRocco
force-pushed
the
remove-from-address-book-mutation
branch
from
8566fce to
015018e
Compare
AlessioRocco
force-pushed
the
remove-from-address-book-mutation
branch
from
015018e to
42113f3
Compare
The mutation accepts an address id as input and removes the address from the current user address book. The raises of the CanCan::AccessDenied exception is needed because Solidus lacks some CanCanCan authorization rules and, in this case, the rule that is missing is the one needed to authorize the address deletion.
Using command "bundle exec rake schema:idl"
AlessioRocco
force-pushed
the
remove-from-address-book-mutation
branch
from
42113f3 to
8540db9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mutation accepts an address id as input and remove the address from the current user address book.