Add addAddressesToCheckout mutation#94
Merged
AlessioRocco merged 4 commits intomasterfrom Apr 17, 2020
Merged
Conversation
AlessioRocco
changed the base branch from
master
to
mark-default-address-mutation
AlessioRocco
force-pushed
the
mark-default-address-mutation
branch
from
e835c3a to
4036e59
Compare
AlessioRocco
force-pushed
the
checkout-address-mutation
branch
2 times, most recently
from
0cc0f73 to
7104fba
Compare
AlessioRocco
changed the base branch from
mark-default-address-mutation
to
master
AlessioRocco
force-pushed
the
checkout-address-mutation
branch
5 times, most recently
from
f8b6395 to
8aa1a1f
Compare
It returned the error paths the wrong way: ["input", "order", "billAddress.firstname" ] the correct way is: ["input", "order", "billAddress", "firstname" ]
AlessioRocco
force-pushed
the
checkout-address-mutation
branch
3 times, most recently
from
e084b71 to
4e5573d
Compare
AlessioRocco
force-pushed
the
checkout-address-mutation
branch
3 times, most recently
from
6cbdfa6 to
ad3ba8b
Compare
AlessioRocco
force-pushed
the
checkout-address-mutation
branch
2 times, most recently
from
67bd6cf to
1972d61
Compare
The mutation accepts billing and shipping address as input and sets it for the current order. In case the shipToBillingAddress argument is true, it ignores the shipping address and instead uses the billing address. It raises a CanCan::AccessDenied exception in case the current ability can't update the current order.
Using command "bundle exec rake schema:idl"
AlessioRocco
force-pushed
the
checkout-address-mutation
branch
from
1972d61 to
102bc17
Compare
ChristianRimondi
approved these changes
Apr 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mutation in this PR accepts billing and shipping addresses as arguments and adds them to the
currentOrder; other argument that can be used isshipToBillingAddressthat isfalseby default.If the
shipToBillingAddressis true the billing address is also used for the shipping address; in case the user provides the shipping address, it will be ignored.