ci(design): gate soliplex_design goldens on the Linux baseline#281
Merged
Conversation
Commit the Linux-rendered golden baseline (regenerated via the update-goldens workflow at the Flutter version pinned in setup-dart-env) and drop --exclude-tags golden so the test job compares against it. Add an if:failure() step uploading the flutter_test diff images so golden failures are inspectable after a red run. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #275, which added
soliplex_designto CI with goldens excluded (--exclude-tags golden) pending a Linux baseline.This commits that baseline and turns on the gate:
update-goldensworkflow (run 26543145206), at the Flutter version pinned repo-wide insetup-dart-env— so the rendering matches what thetestjob compares against.--exclude-tags goldenso thetestjob runs the fullsoliplex_designsuite in compare mode. Goldens are now a real regression gate.if: failure()artifact upload oftest/components/**/failures/, so the flutter_test diff images survive an otherwise-ephemeral red run.This PR's own CI is the proof: if the committed baseline matches Linux rendering, the
testjob goes green.🤖 Generated with Claude Code