refactor(lobby): adopt SoliplexButton across lobby UI#288
Merged
Conversation
Replace raw Material FilledButton/OutlinedButton/TextButton in the lobby screen and server sidebar with the branded SoliplexButton wrapper. The expired-session "Sign in" button (previously FilledButton.tonal, which has no branded equivalent) is promoted to SoliplexButton.filled. Groundwork for the upcoming list/grid view toggle. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Design-system adoption sweep for the lobby module — groundwork for the upcoming list/grid view toggle. Converts all raw Material buttons to the branded
SoliplexButton.server_sidebar.dart— "Add Server"OutlinedButton.icon→SoliplexButton.outlined; the Home / Network Inspector / VersionsTextButtons →SoliplexButton.text.lobby_screen.dart— empty-state "Add Server"FilledButton→SoliplexButton.filled; the expired-session "Sign in"FilledButton.tonal→SoliplexButton.filled.Note on the tonal button
SoliplexButtonhas no tonal variant (Material's medium-emphasis tier between filled and outlined). The expired-session "Sign in" wasFilledButton.tonal; per design decision it's promoted toSoliplexButton.filled(high-emphasis CTA) rather than left as a Material exception. The lobby is now 100% on the branded button.Test plan
grepconfirms zero MaterialFilledButton/OutlinedButton/TextButtoninlib/src/modules/lobby/dart analyzecleanNext
Follow-up PR will add the customer-requested list/grid view toggle on top of this branded lobby.
🤖 Generated with Claude Code