feat(design): SoliplexInput focusNode + readOnly passthroughs#298
Merged
Conversation
Adds two TextField passthroughs the wrapper was missing: - `focusNode` — lets callers drive focus programmatically (e.g. refocusing the field after a submit). - `readOnly` — locks editing while keeping the field's normal, non-greyed styling, for transient busy states where `enabled: false` would be too visually heavy. Both are additive and have no effect at rest, so the input goldens are unchanged. Surfaced while adopting the design system in the room composer, which refocuses its field after each send and freezes input (without greying) while an agent run is in flight. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds two
TextFieldpassthroughs thatSoliplexInputdidn't expose:focusNode— lets callers drive focus programmatically (e.g. refocusing the field after a submit).readOnly— locks editing while keeping the field's normal, non-greyed styling. Unlikeenabled: false, the text stays fully legible and the field remains focusable — for freezing input during a transient busy state.Why
Surfaced while starting the room module design-system adoption. The chat composer refocuses its field after each send (
focusNode.requestFocus()) and setsreadOnly: true(notenabled: false) while an agent run is in flight so the field stays styled normally but locked.SoliplexInputcouldn't express either, which would have forced the app's single most-used input to stay raw Material.Same pattern as #283 (adoption revealed
SoliplexButtonneedediconAlignment).Scope
Both params are additive and have no visual effect at rest — input goldens are unchanged. This is the dependency that unblocks the room-composer adoption PR.
Tests
readOnly blocks edits while staying enabledforwards an external focusNode to the fieldFull
soliplex_design/test/components/inputsuite green (incl. goldens, no drift).🤖 Generated with Claude Code