soliplex_client: pin ag_ui git dep to a fixed ref#333
Merged
Conversation
The ag_ui dependency had no ref, so it floated to upstream HEAD. A fresh resolution (an external consumer with no lockfile — e.g. the klangk soliplex plugin) pulls ag_ui 0.3.0, which retyped ActivitySnapshotEvent.content from Map<String, dynamic> to Object?. That fails to web-compile in soliplex_client (activity_events.dart, agui_event_processor.dart use it as a Map), breaking dart2wasm/dart2js. Pin to d4552e3 — the commit already in pubspec.lock — so resolution is deterministic. No behavior change; all soliplex_client tests pass.
runyaga
force-pushed
the
fix/soliplex-client-content-web-compile
branch
from
db0f313 to
6d14add
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
packages/soliplex_client/pubspec.yamldeclaresag_uias a git dependency with noref, so it floats to upstreamHEAD. Our committedpubspec.lockpinsd4552e3(ag_ui 0.1.0), so CI is fine — but any fresh resolution without our lockfile (an external consumer ofsoliplex_client) pulls whateverHEADis now: ag_ui 0.3.0.ag_ui 0.3.0 retyped
ActivitySnapshotEvent.contentfromMap<String, dynamic>toObject?.soliplex_clientuses it as a map, so the package no longer web-compiles for such consumers:(Hit while consuming
soliplex_clientfrom an external Flutter app —dart2wasm/dart2jsboth fail.)Fix
Pin
ag_uitod4552e3ad0d5e33e34a3df5325260d88ede8bff9— the exact commit already inpubspec.lock. Resolution becomes deterministic for everyone; behavior is unchanged for this repo.Verification
dart analyze→ No issues foundflutter test --exclude-tags integration(packages/soliplex_client) → 1483 tests, all passedpubspec.lockdiff is a single line (ref: HEAD→ref: d4552e3);resolved-refalready matched.Follow-up (not this PR)
Adopting ag_ui 0.3.0 (the
Object? contentAPI) is a separate, larger migration across the monorepo.