Skip to content

Handle multiple modules mixed into another module#277

Merged
solnic merged 1 commit intosolnic:masterfrom
trptcolin:more_module_nesting
Jul 24, 2014
Merged

Handle multiple modules mixed into another module#277
solnic merged 1 commit intosolnic:masterfrom
trptcolin:more_module_nesting

Conversation

@trptcolin
Copy link
Contributor

Looks like my patch in #276 only handled part of the module inclusion issues.

This one handles the case where:

  • you have modules A, B, C, and class X
  • C includes both A and B, and may also have attributes of its own
  • X includes C

Currently, some attributes would get lost depending on what order the includes happened in (see the unit tests).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling 6e62b03 on trptcolin:more_module_nesting into 92b5335 on solnic:master.

@tjstankus
Copy link

👍

solnic added a commit that referenced this pull request Jul 24, 2014
Handle multiple modules mixed into another module
@solnic solnic merged commit 0155c8f into solnic:master Jul 24, 2014
@solnic
Copy link
Owner

solnic commented Jul 24, 2014

thanks again <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants