Merged
Conversation
Add PIN support for make-credential and challenge-response
Contributor
Author
|
if possible it might be nice to replace the "leave empty for no PIN" part with a check whether a PIN exists on the key (if possible) and then if no PIN provided, to not even send the command over |
pr quality fix
Member
|
Thank you! Yes, if a PIN is set, this can be seen in the CTAP2 info which can be collected immediately before makeCredential. So that would be a good enhancement to use. |
Contributor
Author
|
this is great. I have something ready locally just need to get that ready for committing and stuff but ideally I can get this still done today (CET) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PIN support for make-credential and challenge-response