"unconnected's Pet"

[WinterPhoenix]

Details

Occasionally when a player joins with a pet, their pet will say "unconnected's Pet" instead of the player's username.

Steps to reproduce

1. Spawn into the server with a pet with no custom name
2. Observe sometimes it'll think the player's username is "unconnected"

Operating System

Windows

Beta

x86-64 beta

GModPatchTool

Yes, with the up-to-date version of GModPatchTool

[WinterPhoenix]

This is almost certainly an issue with the CachedTexture system not detecting the player's name has changed.

[WinterPhoenix]

It looks like we were using PLAYER.Nick in the player_changename event, which returns the old name, not the new one.