Skip to content

Conversation

@belgattitude
Copy link
Member

Purpose

Allow common dsn configuration for each adapters to soften the differences between implementations

@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2020

🦋 Changeset detected

Latest commit: 40b569e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@soluble/cache-e2e-tests Minor
@soluble/cache-interop Minor
@soluble/cache-ioredis Minor
@soluble/cache-redis Minor
@soluble/dsn-parser Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@belgattitude belgattitude self-assigned this Dec 29, 2020
@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #72 (40b569e) into main (ae21e32) will increase coverage by 1.12%.
The diff coverage is 93.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   85.48%   86.61%   +1.12%     
==========================================
  Files          20       29       +9     
  Lines         489      590     +101     
  Branches      151      183      +32     
==========================================
+ Hits          418      511      +93     
- Misses         71       79       +8     
Flag Coverage Δ
cache_interop_unit 33.20% <0.00%> (-0.68%) ⬇️
cache_ioredis_unit 43.70% <82.25%> (+30.66%) ⬆️
cache_redis_unit 37.40% <73.21%> (?)
dsn_parser_unit 100.00% <100.00%> (ø)
e2e 80.03% <79.20%> (-1.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ache-interop/src/adapter/abstract-cache-adapter.ts 92.68% <ø> (ø)
...ges/cache-interop/src/adapter/map-cache-adapter.ts 95.38% <ø> (+2.84%) ⬆️
packages/dsn-parser/src/dsn-parser.type.ts 100.00% <ø> (ø)
packages/dsn-parser/src/dsn-parser.util.ts 100.00% <ø> (ø)
...es/cache-interop/src/connection/null-connection.ts 20.00% <20.00%> (ø)
packages/cache-redis/src/redis-connection.ts 83.33% <83.33%> (ø)
...es/cache-ioredis/src/ioredis-connection.factory.ts 92.85% <92.85%> (ø)
...ckages/cache-redis/src/redis-connection.factory.ts 92.85% <92.85%> (ø)
...che-interop/src/connection/is-connected-adapter.ts 100.00% <100.00%> (ø)
...ackages/cache-ioredis/src/ioredis-cache-adapter.ts 85.18% <100.00%> (-0.69%) ⬇️
... and 15 more

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Dec 30, 2020

Code Climate has analyzed commit 40b569e and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

@belgattitude belgattitude merged commit c06c1b9 into main Dec 30, 2020
@belgattitude belgattitude deleted the improve-dsn-connection branch December 30, 2020 13:08
This was referenced Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants