Skip to content

Conversation

@belgattitude
Copy link
Member

@belgattitude belgattitude commented Dec 30, 2020

Purpose

Going closer to version 1.0

New features

  • Reworked CacheInterface
    • BC: value is now data
    • Initial support for isHit (needs tests)
    • Export of isSuccess
    • Removal of undocumented features like stats
  • Assertions and typeguards
    • Initial namespaces Asserts and Guards
    • todo remove all exports that are not needed
  • Better validation of cacheKeys (now only string is supported) and no more throw
  • Inner classes improvements (SRP...)
  • Tests, a lot to cover ;)
  • Cleanup tsdoc in CacheInterface, cause now returns InvalidCacheKeyException
  • Doc

Migration

Previously value was holding the data, now data !

@changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2020

🦋 Changeset detected

Latest commit: 1202798

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@soluble/cache-e2e-tests Minor
@soluble/cache-interop Minor
@soluble/cache-ioredis Minor
@soluble/cache-redis Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Dec 30, 2020

Code Climate has analyzed commit 1202798 and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3
Duplication 2

View more on Code Climate.

@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #77 (1202798) into main (3ab8a64) will increase coverage by 4.83%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   86.61%   91.44%   +4.83%     
==========================================
  Files          29       31       +2     
  Lines         590      608      +18     
  Branches      183      181       -2     
==========================================
+ Hits          511      556      +45     
+ Misses         79       52      -27     
Flag Coverage Δ
cache_interop_unit 60.37% <75.00%> (+27.17%) ⬆️
cache_ioredis_unit 43.06% <9.52%> (-0.64%) ⬇️
cache_redis_unit 37.12% <11.76%> (-0.29%) ⬇️
dsn_parser_unit 100.00% <ø> (ø)
e2e 83.33% <84.12%> (+3.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/cache-ioredis/src/ioredis-cache-adapter.ts 86.74% <85.71%> (+1.56%) ⬆️
...ache-interop/src/adapter/abstract-cache-adapter.ts 95.00% <91.66%> (+2.31%) ⬆️
...erop/src/exceptions/invalid-cache-key-exception.ts 93.33% <93.33%> (ø)
packages/cache-redis/src/redis-cache-adapter.ts 88.09% <94.11%> (+2.55%) ⬆️
...ges/cache-interop/src/adapter/map-cache-adapter.ts 98.52% <95.23%> (+3.14%) ⬆️
packages/cache-interop/src/cache-item.factory.ts 100.00% <100.00%> (ø)
packages/cache-interop/src/cache-item.ts 100.00% <100.00%> (+16.00%) ⬆️
...e-interop/src/serializer/native-json-serializer.ts 100.00% <100.00%> (+88.88%) ⬆️
packages/cache-interop/src/utils/typeguards.ts 69.56% <100.00%> (+17.71%) ⬆️
packages/cache-interop/src/validation/asserts.ts 100.00% <100.00%> (ø)
... and 6 more

@belgattitude belgattitude self-assigned this Dec 31, 2020
@belgattitude belgattitude added the enhancement New feature or request label Dec 31, 2020
@belgattitude belgattitude merged commit 01b734e into main Dec 31, 2020
@belgattitude belgattitude deleted the big_refactor branch December 31, 2020 13:02
@github-actions github-actions bot mentioned this pull request Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants