-
Notifications
You must be signed in to change notification settings - Fork 0
Added a first draft of the sdTestEnvironmentShopware #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bin/runInSdTest.sh
Outdated
| VERSION=$1 | ||
|
|
||
| if [ -z "${VERSION}" ]; then | ||
| echo "You must give a version to execute command on, for example 7.1 for PHP 7.1 container." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That not correct.
echo "You must give a version to execute command on, for example 71 for PHP 7.1 container."
(Notice the missing dot in version.)
|
|
||
| if [ ! -f ${PROJECT_DIR}/etc/test/docker-compose.yml ]; then | ||
| echo "No docker-compose.yml file found under ${PROJECT_DIR}/etc/test/docker-compose.yml - Needed for docker setup. Cancel." | ||
| echo "Perhaps forget to run 'vendor/bin/sdTest.sh init'?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot
README.md
Outdated
| Commands (for example to clear the cache or to run the setup) can be executed inside the container. | ||
| You must give a version to execute command on, for example 7.1 for PHP 7.1 container: | ||
|
|
||
| vendor/bin/runInSdTest.sh 7.1 ./app/install.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that won't work; See file bin/runInSdTest.sh
README.md
Outdated
|
|
||
| If you want to you can even get a shell inside the PHP container: | ||
|
|
||
| vendor/bin/runInSdTest.sh 7.1 /bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that won't work; See file bin/runInSdTest.sh
|
Generally: I think choosing nginx is a good idea as it is more lightweight than apache, but for real tests depending on shopware's frontend this will bring us trouble as no url rewriting is done up to now, or am I missing something? |
|
nginx should be ok, we can add some configuration to ensure redirects etc. are working. I will look into it! |
…ntainer with php5.6
… to be able to modify them per project
… the modified configs from the project
…onf automatically / Extracted some locations out of default.conf to be able to reuse it
|
For a fully functional system this pull request (solutionDrive/docker-shopware-container#4) is needed |
|
solutionDrive/docker-shopware-container#4 is merged. |
No description provided.