Skip to content

Conversation

@sd-lueckel
Copy link
Contributor

@sd-lueckel sd-lueckel commented Aug 7, 2018

No description provided.

VERSION=$1

if [ -z "${VERSION}" ]; then
echo "You must give a version to execute command on, for example 7.1 for PHP 7.1 container."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That not correct.

echo "You must give a version to execute command on, for example 71 for PHP 7.1 container."

(Notice the missing dot in version.)


if [ ! -f ${PROJECT_DIR}/etc/test/docker-compose.yml ]; then
echo "No docker-compose.yml file found under ${PROJECT_DIR}/etc/test/docker-compose.yml - Needed for docker setup. Cancel."
echo "Perhaps forget to run 'vendor/bin/sdTest.sh init'?"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot

README.md Outdated
Commands (for example to clear the cache or to run the setup) can be executed inside the container.
You must give a version to execute command on, for example 7.1 for PHP 7.1 container:

vendor/bin/runInSdTest.sh 7.1 ./app/install.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that won't work; See file bin/runInSdTest.sh

README.md Outdated

If you want to you can even get a shell inside the PHP container:

vendor/bin/runInSdTest.sh 7.1 /bin/bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that won't work; See file bin/runInSdTest.sh

@michz
Copy link
Collaborator

michz commented Aug 8, 2018

Generally: I think choosing nginx is a good idea as it is more lightweight than apache, but for real tests depending on shopware's frontend this will bring us trouble as no url rewriting is done up to now, or am I missing something?

@sd-lueckel
Copy link
Contributor Author

nginx should be ok, we can add some configuration to ensure redirects etc. are working. I will look into it!

@sd-lueckel
Copy link
Contributor Author

For a fully functional system this pull request (solutionDrive/docker-shopware-container#4) is needed

@sd-lueckel sd-lueckel changed the title [WIP/RFC] Added a first draft of the sdTestEnvironmentShopware Added a first draft of the sdTestEnvironmentShopware Aug 10, 2018
@michz
Copy link
Collaborator

michz commented Aug 10, 2018

@sd-lueckel sd-lueckel merged commit 0f090bd into master Aug 15, 2018
@sd-lueckel sd-lueckel deleted the first-test-environment branch August 15, 2018 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants