Add support for different shopware versions #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sd-lueckel
requested changes
Dec 19, 2018
Contributor
sd-lueckel
left a comment
sd-lueckel
left a comment
There was a problem hiding this comment.
I think it is ok for now but for the future we should think about a more flexible way
README.md
Outdated
|
|
||
| For all following commands you must pass a php version, e.g. 71 for PHP 7.1 container: | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
I think this newline is not necessary
sd-lueckel
changed the title
sd-lueckel
previously approved these changes
Jan 28, 2019
michz
previously approved these changes
Feb 4, 2019
Jnoack331
previously approved these changes
Feb 4, 2019
…the correct container
… to pass it to docker-command
… so, we don't pass it to docker-exec
sd-lueckel
dismissed stale reviews from Jnoack331, michz, and themself
via
aa790c2
sd-lueckel
force-pushed
the
add-support-for-different-shopware-versions
branch
from
2010f10 to
aa790c2
Compare
sd-lueckel
approved these changes
Feb 6, 2019
michz
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should result in scripts that can handle multiple
shopware-versions and fixes #17 . At the moment the scripts are tied toshopware 5.4.At the moment, the current solution in this PR results in rather ugly calls to the scripts like:
where the parts are:
$ vendor/bin/sdPlugin.sh 70 52 add __________|________ __|__ __|__ __|__ script php-version Shopware-Version subcommandWhat do you think would be a nice way to get rid of this amount of parameters, which are not very self-explanatory.
One possibility could be to run the scripts for all versions and give the user the abiltiy to exclude php-/shopware-versions.