Hardcoded Cancel Vote Index (u32::MAX)

[hman38705]

Description
The logic get_tally(e, market_id, u32::MAX) is used as a heuristic for tracking Cancel votes. Using u32::MAX as a reserved index is undocumented and risk-prone if a market were to theoretically support a very large number of legitimate outcomes. It lacks type safety and clear intention.

Requirements and context

• Define a formal constant or enum variant for the cancellation vote index.
• Centralize the definition in types.rs.

Suggested execution

• Fork the repo and create a branch: git checkout -b refactor/issue-54-cancel-index
• Replace raw literal with named constant.

Implementation changes

• Add pub const CANCEL_OUTCOME_INDEX: u32 = u32::MAX; to types.rs.
• Update cancellation.rs and voting.rs to use this constant.

Test and commit

• Verify that votes cast for the CANCEL_OUTCOME_INDEX are correctly aggregated.

Example commit message
refactor: define and use CANCEL_OUTCOME_INDEX constant instead of raw literal

Guidelines

• Code maintainability.
• Timeframe: 12 hours.

[muhahahmad68]

@muhahahmad68 has applied to work on this issue as part of the Stellar Wave Program's 3rd wave.

Kindly assign this to me

ℹ️ Repo Maintainers: To accept this application, review their application or assign @muhahahmad68 to this issue.

[EmmyKay0026]

@EmmyKay0026 has applied to work on this issue as part of the Stellar Wave Program's 3rd wave.

Hi! I'm ready to tackle this refactoring task with type safety and clear, documented intent within a smart contract's voting logic.

The technical plan involves centralizing the definition of the cancellation index by adding a public constant, CANCEL_OUTCOME_INDEX, within types.rs, explicitly setting it to u32::MAX. I will then perform a codebase-wide audit to replace all raw occurrences of the literal value with this named constant, specifically targeting the logic within cancellation.rs and voting.rs. This transition not only improves code readability but also ensures that the intent behind using the maximum integer value as a reserved index is clearly documented for future developers. To ensure no regression in the tallying logic, I will run the existing test suite and add a specific unit test in the voting module to verify that votes cast using the new constant are correctly aggregated by the get_tally function. Finally, I will ensure that the refactor maintains binary compatibility while significantly enhancing the codebase's adherence to clean coding standards.

The completed refactor, including the centralized type definition and verified voting logic, will be ready in less than 4 hours.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @EmmyKay0026 to this issue.

[Grace-CODE-D]

@Grace-CODE-D has applied to work on this issue as part of the Stellar Wave Program's 3rd wave.

I would like to work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Grace-CODE-D to this issue.

[drips-wave]

Congratulations, @Grace-CODE-D! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on March 30, 2026.

🧑‍💻 @Grace-CODE-D: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been completed by @Grace-CODE-D as part of the Stellar Wave Program's 3rd Wave 🥳

😎 @Grace-CODE-D: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.