fix: implement granular role-based access control for administrative …#230
Merged
hman38705 merged 2 commits intosolutions-plug:mainfrom Mar 26, 2026
Merged
Conversation
…tasks - Segregate Master Admin into functional roles (MarketAdmin, FeeAdmin) - Reserve Master Admin for structural changes (upgrades, role assignments) - Implement Principle of Least Privilege for operational tasks - Add comprehensive role segregation tests - Reduce blast radius of compromised admin keys - Minimize master admin on-chain exposure Changes: - Added require_market_admin() and require_fee_admin() functions - Updated 7 modules to use role-specific authorization - Added 10 comprehensive test cases - No breaking changes to contract interface Closes solutions-plug#118
|
@Hexstar-labs Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Segregate Master Admin into Functional Roles
Changes
require_market_admin()andrequire_fee_admin()authorization functionsRole Matrix
Benefits
Testing
Closes #118