Skip to content

feat(#246): add tie-handling tests for dispute voting#324

Merged
hman38705 merged 1 commit intosolutions-plug:mainfrom
Kingsman-99:feature/issue-246-tie-handling-tests
Mar 27, 2026
Merged

feat(#246): add tie-handling tests for dispute voting#324
hman38705 merged 1 commit intosolutions-plug:mainfrom
Kingsman-99:feature/issue-246-tie-handling-tests

Conversation

@Kingsman-99
Copy link
Copy Markdown
Contributor

  • test_two_way_tie_returns_no_majority
  • test_three_way_tie_at_top_returns_no_majority
  • test_all_outcomes_tied_returns_no_majority
  • test_exact_60_percent_is_not_a_tie (boundary guard)
  • test_admin_fallback_allowed_after_tie

Updated .gitignore to exclude snapshots, build artifacts, Cargo.lock

Pull Request

📋 Description

Brief description of the changes in this PR.

🎯 Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring
  • Test addition/update
  • CI/CD update

🔗 Related Issues

Closes #246

📝 Changes Made

  • Change 1
  • Change 2
  • Change 3

🧪 Testing

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • All tests passing locally
  • Test coverage maintained/improved

Manual Testing

  • Tested on testnet
  • Tested locally
  • Edge cases tested

By submitting this PR, I confirm that:

  • I have read and followed the CONTRIBUTING.md guidelines
  • My code follows the project's coding standards
  • I have tested my changes thoroughly
  • I am ready for code review

- test_two_way_tie_returns_no_majority
- test_three_way_tie_at_top_returns_no_majority
- test_all_outcomes_tied_returns_no_majority
- test_exact_60_percent_is_not_a_tie (boundary guard)
- test_admin_fallback_allowed_after_tie

Updated .gitignore to exclude snapshots, build artifacts, Cargo.lock
@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented Mar 27, 2026

@Kingsman-99 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@hman38705 hman38705 merged commit d0295a4 into solutions-plug:main Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tie-handling tests for dispute voting

2 participants