fix: synchronize errors.rs with missing enum variants#335
Merged
hman38705 merged 1 commit intosolutions-plug:mainfrom Mar 27, 2026
Merged
fix: synchronize errors.rs with missing enum variants#335hman38705 merged 1 commit intosolutions-plug:mainfrom
hman38705 merged 1 commit intosolutions-plug:mainfrom
Conversation
|
@maztah1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- Deduplicate ErrorCode enum main had 150+ duplicate variants causing the Soroban contracterror 50-variant limit to be exceeded - Add StalePrice = 29 and AssetClawedBack = 32 as canonical definitions - Add TransferFailed = 33 for SAC programmatic transfer failures - All 50 variants are unique, sequential, and cover every ErrorCode reference used across the module suite (sac.rs, oracles.rs, etc.) Closes solutions-plug#113 / issue-5
e7f10a2 to
b392a83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #113 (issue #5 — Define Missing SAC and Oracle Error Codes)
Problem
The contract referenced ErrorCode::AssetClawedBack and ErrorCode::StalePrice that were either missing or the enum exceeded Soroban SDK's 50-variant limit for #[contracterror], causing compilation failures.
Changes
Core Fix
SAC Module
Oracle Module
Supporting Fixes
Verification
cargo build --manifest-path contracts/predict-iq/Cargo.toml
Finished dev profile — no errors