fix: enforce proxy trust boundaries for x-forwarded-for (closes #379)#436
Merged
hman38705 merged 1 commit intosolutions-plug:mainfrom Mar 30, 2026
Merged
Conversation
|
@jemilahabiodun-oss Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce Trusted Proxy Boundaries for x-forwarded-for Handling
Overview
This PR strengthens request security by enforcing trusted proxy boundaries when handling the
x-forwarded-forheader.Description
Currently, the
x-forwarded-forheader is trusted without validating the source of the request.This creates a security risk, as malicious clients can spoof IP addresses.
This PR introduces configurable trusted proxy CIDRs and ensures that forwarded headers are only honored when requests originate from trusted sources.
Problem
x-forwarded-foris trusted without validationChanges
x-forwarded-foronly from known proxy rangesservices/api/src/security.rsservices/api/src/handlers.rsAcceptance Criteria
Impact
Testing
Notes
Closes Harden client IP extraction for trusted proxy setups #379