fix: resolve compile errors from issues #477-#480

[Realericky]

Summary

---

#477 — Fix duplicate get_dispute_window and dead constant usage

File: modules/resolution.rs

Already resolved in the codebase: DISPUTE_WINDOW_SECONDS is defined and a single get_dispute_window() implementation exists. No code change required.

---

#478 — Add missing timelock config key and bounds constants

File: types.rs, modules/governance.rs

Already resolved: ConfigKey::TimelockDuration, TIMELOCK_MIN_SECONDS, and TIMELOCK_MAX_SECONDS are all defined in types.rs and imported correctly in governance.rs. No code change required.

---

#479 — Fix PendingGuardianRemoval field name mismatch

File: modules/governance.rs

PendingGuardianRemoval in types.rs declares the field as target_guardian, but governance.rs referenced it as .address in two places:

• The struct literal in remove_guardian
• The filter comparison in vote_on_guardian_removal

Both corrected to use .target_guardian.

---

#480 — Fix missing oracle_id argument in oracle result event

File: modules/oracles.rs

emit_oracle_result_set in events.rs has the signature:

fn emit_oracle_result_set(e, market_id, oracle_id: u32, oracle_source: Address, outcome: u32)

The call site in set_oracle_result was passing only 4 arguments (omitting oracle_id). Fixed by passing 0u32 as the oracle_id, consistent with the rest of the codebase and the existing event tests.

---

Testing

Static analysis confirms all call sites and struct field references are now consistent with their definitions. Cargo is not available in this environment; CI will provide full build verification.

Closes #477
Closes #478
Closes #479
Closes #480

[drips-wave]

@Realericky Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits