Add expectation tier function for non-members by DevSDK · Pull Request #23 · solved-ac/plugin

DevSDK · 2019-11-06T00:10:48Z

Before this function implemented, user cannot know where they are
and what are the proper problems without tier

This function works following steps

Parse the solved problem in user page
Get Level information from Api server
Calculate the total exp point from level information
Display expectation tier

Thanks
Seokho

Before this function implemented, user cannot know where they are and what are the proper problems without tier This function works following steps 1. Parse the solved problem in user page 2. Get Level information from Api server 3. Calculate the total exp point from level information 4. Display expectation tier Signed-off-by: Seokho Song <0xdevssh@gmail.com>

shiftpsh

Thank you for your pull request, I've reviewed your code and requested some changes.

Although, this is extremely inefficient for users with like >1000 solved problems; it will wait for the plugin to process >1000 requests. Maybe in future I'll make a separate endpoint that calculates this information.

shiftpsh · 2019-11-07T06:10:38Z

-                                        + "</a>"
+
+        if(!userData && isShowUserTempTier)
+        {


Please use K&R style brackets.

shiftpsh · 2019-11-07T06:14:03Z

+        if(!userData && isShowUserTempTier)
+        {
+            var acceptPanel = document.querySelector(".panel.panel-default")
+            var acceptProblems = acceptPanel.querySelectorAll(".problem_number>a")


Since BOJ and solved.ac calculates accepted problems differently, the actual experience points calculated from this method will differ from official calculation. See https://solved.ac/faq/

Could you explain more details?
I'm not sure what I need to change on this part.

If problem is marked with tag 'Preparing Judge', it should not be calculated as accepted.

Does api server respond 'level 0' if the problem that was tagged 'preparing judge'?

shiftpsh · 2019-11-07T06:15:06Z

+    const levelData = [320, 480, 912, 1642, 2791, 4465, 6698, 9913, 14472, 20840, 29593, 
+                       41431, 57588, 79472, 108877, 148072, 200638, 270862, 364309, 488174, 
+                       651712, 866777, 1148479, 1515993, 1993531, 2611525, 3408040, 4430452,
+                       5737436, 7401292, 9510661]


Level experience points are subject to change, it should NOT be declared as constants. Please use https://api.solved.ac/exp_table.php

If we had an api document(or just list), it would be great to develop some of functions.

I will document APIs in the future, but it's a shame that I'm currently too busy to make and publish documented APIs.

shiftpsh · 2019-11-07T06:17:27Z

+    const expTable = [0, 4800, 15740, 38720, 83400, 163700, 298000, 785400, 1202800, 1795000, 2834700,
+                      4276000, 6261000, 8982000, 12704000, 18796000, 26842000, 37941000, 52792000, 
+                      720000000, 152000000, 213000000, 294000000, 380000000, 639000000, 1000000000, 
+                      1200000000, 1500000000]


Tier bounds are also subject to change, hence it should NOT be declared as constants. Currently we don't have API endpoints for this, I'll fix it later.

Yes it does, but its experience points has to be calculated as zero.

Please change this to use https://api.solved.ac/exp_cap.php.

shiftpsh · 2019-11-07T06:18:32Z

+
+        <div class="option_item" data-key="show_userpage_temp_tier">
+            <span class="option_caption">
+                유저페이지 임시티어 보기


Please change it to "사용자 페이지에서 비공식 티어 보기".

shiftpsh · 2019-11-07T06:21:04Z

+
+            var expectLevel = getExpectLevelFromExpPoint(totalExpPoint)
+            newRowHeader.innerText = "solved.ac 임시티어"
+            newRowDescription.innerHTML = "<a href=\"https://boj.com/" + userId + "\">"


What's with boj.com? It links to some random premium domain broker site.

It's my mistake, I'll fix to boj.kr or acmicpc.net.

DevSDK · 2019-11-07T11:50:37Z

Please check my commit that your request has been resolved!

1. Fix missed coding style code to k&r style 2. Replace option menu 3. Replace constant exp point table to server based table 4. Fix URL on expectation tier 5. Ignore level 0 problem to calculate total exp point Signed-off-by: Seokho Song <0xdevssh@gmail.com>

DevSDK · 2019-11-08T03:20:50Z

Fix missed K & R style from e211899 to c467e18; a blank space.
:)

shiftpsh · 2019-11-12T04:22:40Z

I'm currently too busy preparing problems for Sogang Programming Contest. I'll take a look when I'm not busy. Thanks.

DevSDK · 2019-11-12T04:24:14Z

Ah Okay! Take a time!

shiftpsh

Please fix some trivial formatting errors, and I think we're good to go.

shiftpsh · 2019-11-26T04:56:26Z

+    const expTable = [0, 4800, 15740, 38720, 83400, 163700, 298000, 785400, 1202800, 1795000, 2834700,
+                      4276000, 6261000, 8982000, 12704000, 18796000, 26842000, 37941000, 52792000, 
+                      720000000, 152000000, 213000000, 294000000, 380000000, 639000000, 1000000000, 
+                      1200000000, 1500000000]


Please change this to use https://api.solved.ac/exp_cap.php.

shiftpsh · 2019-11-26T04:57:33Z

+                      4276000, 6261000, 8982000, 12704000, 18796000, 26842000, 37941000, 52792000, 
+                      720000000, 152000000, 213000000, 294000000, 380000000, 639000000, 1000000000, 
+                      1200000000, 1500000000]
+    for(i=0;i<expTable.length-1;i++) {


Code is not well-formatted; there must be spaces between operands and operators.

Add spaces between operands and opraters Replace from constant exp table to exp table fetched from api Signed-off-by: Seokho Song <0xdevssh@gmail.com>

DevSDK · 2019-11-27T13:34:47Z

And here we go!

shiftpsh

LGTM

shiftpsh added enhancement New feature or request good first issue Good for newcomers labels Nov 7, 2019

shiftpsh suggested changes Nov 7, 2019

View reviewed changes

DevSDK force-pushed the master branch from e211899 to c467e18 Compare November 8, 2019 03:17

DevSDK requested a review from shiftpsh November 8, 2019 03:22

shiftpsh suggested changes Nov 26, 2019

View reviewed changes

Update expTable from API and Fixed formattings

b1801b5

Add spaces between operands and opraters Replace from constant exp table to exp table fetched from api Signed-off-by: Seokho Song <0xdevssh@gmail.com>

DevSDK requested a review from shiftpsh November 27, 2019 13:34

shiftpsh approved these changes Nov 27, 2019

View reviewed changes

shiftpsh merged commit b7d4093 into solved-ac:master Nov 27, 2019

Uh oh!

Conversation

DevSDK commented Nov 6, 2019

Uh oh!

shiftpsh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DevSDK Nov 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DevSDK Nov 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DevSDK commented Nov 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DevSDK commented Nov 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shiftpsh commented Nov 12, 2019

Uh oh!

DevSDK commented Nov 12, 2019

Uh oh!

shiftpsh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DevSDK commented Nov 27, 2019

Uh oh!

shiftpsh left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

DevSDK Nov 7, 2019 •

edited

Loading

DevSDK Nov 7, 2019 •

edited

Loading

DevSDK commented Nov 7, 2019 •

edited

Loading

DevSDK commented Nov 8, 2019 •

edited

Loading